Merged
Conversation
danielebriggi
approved these changes
Sep 18, 2025
Member
danielebriggi
left a comment
There was a problem hiding this comment.
your fake key/value is undoubtedly better!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve test speed by avoiding debug log level
Description of change
The
should commands accept bindingstest fromdatabase.test.tswas incorrectly using theSET KEY log_level TO debugcommand.In an earlier commit (chore(test): fix a typo in the database test), I mistakenly treated the absence of log_level as a typo. In reality, the test was intentionally written not to modify the log level.
This change restores the intended behavior and makes it explicit that the test must avoid changing the log level, since doing so can cause subsequent tests to run much more slowly.
Pull-Request Checklist
mainbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000