Fixed hanging on stdin in API mode. #4657
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed regression introduced in 1.4.11
|
Hello @stamparm |
|
I had the same problem. When I ran the sqlmap.py program in the corresponding directory in PyCharm using os.system(), it prompted me with the following message： |
|
@pdelagrave sorry man, i didn't get a notification for this in my email. on it |
stamparm
added a commit
that referenced
this pull request
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed regression introduced in 1.4.11
EDIT: initial instructions to reproduce was incorrect.
sqlmap assumed that if stdin was present and wasn't a TTY, then it must expect and read a target list from stdin.
In API mode (i.e. lauched by
sqlmapapi.py), sqlmap will have a valid stdin file and won't be a TTY, yet we don't want to use the stdin to pass a target list, all the configuration is to be passed via the-c fileoption.This caused sqlmap to be unusable in API mode with
sqlmapapi.py; executions would stall early with that log message:using 'STDIN' for parsing targets list.