Use telephoto for panning and zooming #1422
Conversation
| scope.launch { | ||
| // TODO: this doesn't work super well. | ||
| // Probably because of https://github.com/saket/telephoto/issues/135? | ||
| zoomableState.zoomTo( |
There was a problem hiding this comment.
From local testing this isn't adjusting the pan at all when selecting a node.
There was a problem hiding this comment.
This should be fixed by saket/telephoto@68fcaef. Do you mind if I update telephoto to its latest snapshot version?
| Box( | ||
| modifier = modifier.onSizeChanged { | ||
| appWindowSize = it | ||
| // TODO: do we want to draw behind the search bar? |
There was a problem hiding this comment.
I think drawing behind the search looks correct, which is what it's doing already, if we didn't allow it there would be a jarring cutoff.
There was a problem hiding this comment.
In that case, do you want to synchronize the content padding below with the search box's height?
There was a problem hiding this comment.
I'm not sure, I think it was looking good how it was now.
|
|
||
| val focusRequester = remember { FocusRequester() } | ||
| LaunchedEffect(zoomableState) { | ||
| // Request focus to receive keyboard shortcuts. |
There was a problem hiding this comment.
This is turning out to be more complex than I expected. The content starts in a focused state but loses focus when the search box is clicked. We'll have to restore focus when a search result is selected. Let me try fixing this.
Re-opened: #1421