feat(cli): mir opens your machines — the live overview (O1) - #97

Fetch TURN credentials from the selected relay

When the selected machine's SignalURL differs from defaults.SignalURL(), this prewarm stores TURN credentials minted by the default relay and attach later passes them to client.Attach through ov.ice(). Prewarm.ICEFrom explicitly documents that credentials must not be reused for another relay, so overview attaches that require TURN behind strict NATs will fail for custom/federated-relay machines; resolve or cache ICE using the selected machine's relay before dialing.

Useful? React with 👍 / 👎.

Pass the selected state directory into the overview

When mir attach --dir <custom> has multiple machines and no valid last-used target, this fallback calls cmdOverview(), which unconditionally loads defaultClientDir() rather than <custom>. The command therefore switches identities and displays the default machine list after having resolved the decision from the custom directory; make the overview accept and retain the parsed directory.

Useful? React with 👍 / 👎.

Stop the prior stdin reader before redialing

After a transport drop, ClientBridgeSink can return from its receive goroutine while its stdin goroutine remains blocked in detachFilter.Read, because canceling the bridge context does not unblock that read. ReconnectLoopWith then invokes this callback again with the same in, leaving multiple goroutines competing for the pump; the stale reader can consume the first keystrokes after reconnection and attempt to send them on the closed connection. Use one persistent input forwarder or make each bridge read cancelable and wait for it to exit before redialing.

Useful? React with 👍 / 👎.

TURN credentials freeze after first refresh

Medium Severity

refresh requests TURN only on the first tick and stores the result in ov.iceList for the rest of the run. Later ticks pass an empty turnURL, so the T2 ICE cache is never consulted again. Relay credentials expire after 15 minutes, and a failed first fetch is never retried, so Enter from a long-lived overview can attach with dead or missing TURN.

 

^{Reviewed by Cursor Bugbot for commit 5f69ca0. Configure here.}

Windows map written without synchronization

Medium Severity

The WindowsSink writes ov.windows from the bridge receive goroutine, while the main loop reads that map after attach returns and again in refresh. ClientBridgeSink does not wait for the receive goroutine to exit, so those accesses overlap. Concurrent map read/write can panic.

 

^{Reviewed by Cursor Bugbot for commit 5f69ca0. Configure here.}

Reconnect races the shared detach filter

Medium Severity

One detachFilter is reused for every ReconnectLoopWith session. When a drop ends the bridge via the receive side, the previous stdin goroutine stays blocked in detachFilter.Read. The next session starts a second Read on the same filter. Keystrokes after a reconnect can be stolen by the dead session, and a split Ctrl-O d can miss the detach.

 

^{Reviewed by Cursor Bugbot for commit 5f69ca0. Configure here.}

Rename leaves last-used name stale

Low Severity

Last-used is stored by display name and is not updated when that machine is renamed. pickDefaultMachine and the overview cursor both look up LastUsed by name, so after a rename the continue path no longer finds the machine the user was on.

 

^{Reviewed by Cursor Bugbot for commit 5f69ca0. Configure here.}

Overview ignores attach directory flag

Low Severity

When a bare mir attach --dir … has no default target, it calls cmdOverview, which always uses defaultClientDir(). Discovery used --dir, but the picker then shows a different state directory.

 

^{Reviewed by Cursor Bugbot for commit 5f69ca0. Configure here.}