Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve terminal attention notifications#2562

Open
Jinwoo-H wants to merge 1 commit into
mainfrom
jinwoo0825/persistant-terminal-highlight
Open

Improve terminal attention notifications#2562
Jinwoo-H wants to merge 1 commit into
mainfrom
jinwoo0825/persistant-terminal-highlight

Conversation

@Jinwoo-H
Copy link
Copy Markdown
Contributor

@Jinwoo-H Jinwoo-H commented May 21, 2026

Summary

  • Gate mobile push dispatch behind the same notification settings, focus, cooldown, and explicit-test suppression as desktop notifications.
  • Add a persistent pane-level terminal attention ring for BEL and agent-complete events.
  • Clear pane attention on pane interaction, pane close, and terminal shutdown, and ignore stale pane completions before dispatch.

Test plan

  • pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/terminal-pane/use-notification-dispatch.test.ts src/renderer/src/components/terminal-pane/use-terminal-pane-lifecycle.test.ts src/renderer/src/components/terminal-pane/pty-connection.test.ts src/main/ipc/notifications.test.ts
  • pnpm run typecheck:web
  • pnpm run typecheck:node
  • git diff --check

Made with Orca 🐋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant