Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Gate Checks Create PR by branch work#2594

Open
brennanb2025 wants to merge 1 commit into
mainfrom
brennankbenson/ai-commit-settings
Open

Gate Checks Create PR by branch work#2594
brennanb2025 wants to merge 1 commit into
mainfrom
brennankbenson/ai-commit-settings

Conversation

@brennanb2025
Copy link
Copy Markdown
Contributor

@brennanb2025 brennanb2025 commented May 22, 2026

Summary

  • Show the Checks-tab Create PR action only when shared hosted-review eligibility says the branch can actually create a review.
  • Make no committed branch work a first-class eligibility block so Source Control, Checks, and main-process submit preflight all agree on canCreate.
  • Keep Push & Create PR available for local commits that need to be pushed before review creation.

Validation

  • pnpm run typecheck
  • pnpm run lint
  • git diff --check 0fa566e8..HEAD
  • Focused Vitest: src/main/source-control/hosted-review-creation.test.ts, source-control-dropdown-items.test.ts, source-control-primary-action.test.ts (63 tests)
  • Launched the exact PR worktree in Electron and verified window.api.app.getIdentity() returned brennankbenson/ai-commit-settings
  • Disposable demo-repo no-delta branch: UI showed 0 commits ahead, Create PR was disabled with Commit changes first, and direct submit returned Create PR failed: commit changes before creating a pull request.
  • Disposable demo-repo with-delta branch: backing git showed origin/main..HEAD = 1, UI showed the inline New pull request form, prefilled title/body, and enabled Create PR
  • Clicked enabled Create PR against a fake non-Orca GitHub repo; the flow reached GitHub creation and failed only because the fake repo did not exist
  • Removed the temporary repo registration/files and stopped the Electron dev app
  • Live SSH hosted-review eligibility: attempted with a throwaway SSH target; relay connected/deployed, but renderer-side SSH git IPC hung before producing usable evidence. Unit coverage still exercises the SSH-provider rev-list --count path.

@brennanb2025 brennanb2025 force-pushed the brennankbenson/ai-commit-settings branch from 2d991c1 to f25d34f Compare May 22, 2026 04:46
@brennanb2025 brennanb2025 changed the title Make AI commit setup explicit Show Create PR in checks empty state May 22, 2026
@brennanb2025 brennanb2025 force-pushed the brennankbenson/ai-commit-settings branch from f25d34f to 67ce370 Compare May 22, 2026 05:00
@brennanb2025 brennanb2025 changed the title Show Create PR in checks empty state Gate Checks Create PR by branch work May 22, 2026
@brennanb2025 brennanb2025 force-pushed the brennankbenson/ai-commit-settings branch from 67ce370 to 4525ede Compare May 22, 2026 05:07
@brennanb2025 brennanb2025 force-pushed the brennankbenson/ai-commit-settings branch from 4525ede to c4582b0 Compare May 22, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant