Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix unified workspace options regression#2619

Merged
nwparker merged 1 commit into
mainfrom
nwparker/filter-regression
May 22, 2026
Merged

Fix unified workspace options regression#2619
nwparker merged 1 commit into
mainfrom
nwparker/filter-regression

Conversation

@nwparker
Copy link
Copy Markdown
Contributor

Summary

  • Restore the sidebar header to the single unified Workspace options button instead of separate Edit filters and View options controls.
  • Keep the Settings shortcut recorder from being preempted by main-process and renderer app shortcut routing, so existing app shortcuts can be captured for rebinding.
  • Add regression coverage for the main-process shortcut interception case.

PR #2581 audit

Testing

  • pnpm exec vitest run --config config/vitest.config.ts src/main/window/createMainWindow.test.ts src/shared/keybindings.test.ts src/main/keybindings/keybinding-file.test.ts src/main/ipc/keybindings.test.ts src/main/menu/register-app-menu.test.ts src/shared/window-shortcut-policy.test.ts src/renderer/src/web/web-preload-api.test.ts src/renderer/src/components/terminal-pane/keyboard-handlers.test.ts src/renderer/src/components/terminal-pane/terminal-shortcut-policy.test.ts src/main/browser/browser-manager.test.ts src/main/browser/browser-manager-grab.test.ts
  • pnpm run typecheck:web
  • pnpm run typecheck:node
  • pnpm exec oxlint src/main/window/createMainWindow.test.ts src/main/window/createMainWindow.ts src/preload/api-types.ts src/preload/index.ts src/renderer/src/App.tsx src/renderer/src/components/settings/ShortcutBindingRow.tsx src/renderer/src/components/sidebar/SidebarHeader.tsx src/renderer/src/web/web-preload-api.ts
  • git diff --check
  • Electron visual verification on this worktree via CDP: saw one Workspace options button, no Edit filters or View options buttons, and verified the unified menu contains grouping, sort, filters, properties, and project controls. Also verified the Shortcuts recorder enters the focused Press keys state and cancels cleanly.

@nwparker nwparker merged commit 8c6d0c3 into main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant