Greptile Overview

Greptile Summary

Adds tracking and display of subscription renewal transactions by creating a new SubscriptionInvoice database table and integrating it with the existing transactions system.

Key Changes:

• New SubscriptionInvoice model stores Stripe invoice records with isSubscriptionCreationInvoice flag to distinguish initial subscriptions from renewals
• handleStripeInvoicePaid function processes invoice.payment_succeeded webhooks and stores invoice data
• buildSubscriptionRenewalTransaction creates transaction entries for subscription renewals (money transfers only, no product grants)
• Transaction listing API now queries subscription invoices and filters out creation invoices to show only renewals
• Cursor pagination extended to support the new subscription invoice data source
• Comprehensive test coverage verifies that subscription creation invoices are excluded from the renewal transaction list

Minor Changes:

• Fixed incorrect database port in docker compose configuration (8128 → 5432)
• UI improvements: replaced em dash with hyphen, migrated to DateCell component
• Removed unused imports and fixed formatting inconsistencies

Confidence Score: 3/5

• This PR has one critical bug that will cause runtime errors when processing subscription renewals without USD pricing
• The implementation is well-structured with proper database migrations, comprehensive tests, and good separation of concerns. However, there's a critical bug in buildSubscriptionRenewalTransaction at line 283 where chargedAmount.USD is accessed without null checking, which will fail if a subscription doesn't have USD pricing. This violates the schema requirement that net_amount.USD must be a string.
• Pay close attention to apps/backend/src/app/api/latest/internal/payments/transactions/transaction-builder.ts - the USD amount handling bug must be fixed before merging

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant Stripe
    participant Webhook as Stripe Webhook Handler
    participant Handler as handleStripeInvoicePaid
    participant DB as Database
    participant API as Transactions API
    participant UI as Dashboard UI

    Note over Stripe,DB: Subscription Renewal Flow
    
    Stripe->>Webhook: invoice.payment_succeeded event
    Webhook->>Webhook: processStripeWebhookEvent()
    Webhook->>Webhook: syncStripeSubscriptions()
    Note over Webhook: Updates subscription status
    
    Webhook->>Handler: handleStripeInvoicePaid(stripe, accountId, invoice)
    Handler->>Handler: Extract subscription ID from invoice lines
    Handler->>Handler: Check billing_reason for subscription_create
    Handler->>DB: upsert SubscriptionInvoice
    Note over DB: Stores invoice with<br/>isSubscriptionCreationInvoice flag
    
    Note over API,UI: Transaction Display Flow
    
    UI->>API: GET /api/latest/internal/payments/transactions
    API->>DB: Query subscriptions
    API->>DB: Query itemQuantityChanges
    API->>DB: Query oneTimePurchases
    API->>DB: Query subscriptionInvoices<br/>(WHERE isSubscriptionCreationInvoice = false)
    DB-->>API: Return filtered invoices
    
    API->>API: buildSubscriptionRenewalTransaction()<br/>for each invoice
    API->>API: Merge & sort all transactions
    API->>API: Apply cursor pagination
    API-->>UI: Return transactions list

_{11 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}