capture freestyle error #969

BilalG1 · 2025-10-22T02:19:43Z

Summary by CodeRabbit

Bug Fixes
- Improved email rendering reliability by detecting and handling cases where template executions produce no result, preventing silent failures.
- Enhanced error reporting for both single and batched email generation so failures are captured and surfaced more consistently for faster diagnosis.

vercel · 2025-10-22T02:19:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
stack-backend	Ready	Preview	Comment	Oct 27, 2025 4:58pm
stack-dashboard	Ready	Preview	Comment	Oct 27, 2025 4:58pm
stack-demo	Ready	Preview	Comment	Oct 27, 2025 4:58pm
stack-docs	Ready	Preview	Comment	Oct 27, 2025 4:58pm

coderabbitai · 2025-10-22T02:19:54Z

Walkthrough

Added defensive guards in two email-rendering functions to detect a missing execution result. When executeResult.data.result is absent, the code constructs a StackAssertionError with full context, calls captureError with a specific tag, and throws the error; successful paths now read from executeResult.data.result.

Changes

Cohort / File(s)	Change Summary
Email rendering error guards `apps/backend/src/lib/email-rendering.tsx`	Added `captureError` import. Renamed execution output variable to `executeResult`. Added post-execution guards in `renderEmailWithTemplate` and `renderEmailsWithTemplateBatched` to detect missing `executeResult.data.result`: on missing result create a `StackAssertionError` with contextual data, call `captureError` with a tag (`"freestyle-no-result"`), and re-throw the error. Updated success returns to use `executeResult.data.result`.

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant Renderer as EmailRenderer
  participant Executor as FreestyleExecutor
  Caller->>Renderer: renderEmailWithTemplate(...)
  Renderer->>Executor: execute(freestyle, inputs)
  Executor-->>Renderer: executeResult (status / data)
  alt executeResult has data.result
    Renderer-->>Caller: return executeResult.data.result
  else missing data.result
    Renderer->>Renderer: build StackAssertionError(context)
    Renderer->>Renderer: captureError(error, "freestyle-no-result")
    Renderer--xCaller: throw StackAssertionError
  end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Points to review:

Verify the constructed StackAssertionError includes the intended contextual fields.
Confirm captureError tag string and any logging/telemetry expectations.
Ensure callers handle the thrown error as expected.

Poem

🐰 With nimble paws I guard each run,

If results are lost, I’ll catch the fun.
I bundle context, shout “no-result” clear,
Then toss the error for devs to hear.
Hooray—no ghosts in renders here!

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description is entirely empty, containing only the template HTML comment with no substantive content. No explanation of the changes, rationale, testing approach, or other relevant context is provided. While the format technically matches the template structure, the description fails to provide any meaningful information about what the PR accomplishes or why these changes are necessary, making it largely incomplete.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "capture freestyle error" directly aligns with the main changes in this pull request. The changeset adds error capturing functionality to the email rendering functions (renderEmailWithTemplate and renderEmailsWithTemplateBatched) by introducing guards for missing results and using captureError to log assertion errors. The title is concise and specific enough that it clearly conveys the primary intent of the changes without unnecessary verbosity.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch capture-freestyle-error

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5841c32 and 9b612c0.

📒 Files selected for processing (1)

apps/backend/src/lib/email-rendering.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/backend/src/lib/email-rendering.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: restart-dev-and-test
GitHub Check: build (22.x)
GitHub Check: build (22.x)
GitHub Check: setup-tests
GitHub Check: docker
GitHub Check: check_prisma_migrations (22.x)
GitHub Check: lint_and_build (latest)
GitHub Check: build (22.x)
GitHub Check: restart-dev-and-test-with-custom-base-port
GitHub Check: all-good
GitHub Check: Security Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps

Greptile Overview

Summary

Added defensive error handling in email rendering functions to detect and capture cases where Freestyle script execution succeeds but returns no result.

Checks for missing executeResult.data.result after successful Freestyle execution in both renderEmailWithTemplate and renderEmailsWithTemplateBatched
Uses captureError to log diagnostic information when this edge case occurs
Returns user-friendly error message instead of allowing undefined to propagate

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The change adds defensive error handling for an edge case without modifying existing logic paths. The pattern is consistent across both functions and follows existing error handling conventions in the codebase.
No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/backend/src/lib/email-rendering.tsx	5/5	Added defensive error handling to capture and log cases where Freestyle execution succeeds but returns no result

Sequence Diagram

sequenceDiagram
    participant Caller
    participant EmailRenderer
    participant Freestyle
    participant ErrorCapture

    Caller->>EmailRenderer: renderEmailWithTemplate()
    EmailRenderer->>EmailRenderer: bundleJavaScript()
    EmailRenderer->>Freestyle: executeScript()
    
    alt Execution Error
        Freestyle-->>EmailRenderer: Result.error(error)
        EmailRenderer-->>Caller: Return error
    else Execution Success
        Freestyle-->>EmailRenderer: Result.ok(data)
        EmailRenderer->>EmailRenderer: Check if data.result exists
        
        alt No Result (New Check)
            EmailRenderer->>ErrorCapture: captureError("freestyle-no-result")
            EmailRenderer-->>Caller: Return error message
        else Result Exists
            EmailRenderer-->>Caller: Return Result.ok(data.result)
        end
    end

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

apps/backend/src/lib/email-rendering.tsx

capture freestyle error

5841c32

github-actions bot assigned BilalG1 Oct 22, 2025

greptile-apps bot reviewed Oct 22, 2025

View reviewed changes

Merge dev into capture-freestyle-error

c6856e6

BilalG1 assigned N2D4 and unassigned BilalG1 Oct 22, 2025

BilalG1 requested a review from N2D4 October 22, 2025 22:56

Merge dev into capture-freestyle-error

da2b81f

N2D4 reviewed Oct 23, 2025

View reviewed changes

apps/backend/src/lib/email-rendering.tsx Outdated Show resolved Hide resolved

N2D4 reviewed Oct 23, 2025

View reviewed changes

apps/backend/src/lib/email-rendering.tsx Outdated Show resolved Hide resolved

N2D4 reviewed Oct 23, 2025

View reviewed changes

apps/backend/src/lib/email-rendering.tsx Show resolved Hide resolved

N2D4 approved these changes Oct 23, 2025

View reviewed changes

github-actions bot assigned BilalG1 and unassigned N2D4 Oct 23, 2025

N2D4 and others added 4 commits October 24, 2025 04:32

Merge dev into capture-freestyle-error

caa2b7d

Merge dev into capture-freestyle-error

b42a813

Merge dev into capture-freestyle-error

d020f07

throw noResultError

9b612c0

BilalG1 merged commit 7bf554e into dev Oct 27, 2025
20 checks passed

BilalG1 deleted the capture-freestyle-error branch October 27, 2025 17:17

coderabbitai bot mentioned this pull request Oct 30, 2025

Payment transactions #990

Merged

coderabbitai bot mentioned this pull request Dec 20, 2025

Email Rendering Issue #1075

Open

coderabbitai bot mentioned this pull request Jan 8, 2026

Update email rendering code to use latest version of freestyle and to have a fallback with vercel sandbox #1091

Merged

coderabbitai bot mentioned this pull request Jan 20, 2026

[Fix]: Add better and more informative error handling to email-rendering engines #1124

Merged

coderabbitai bot mentioned this pull request Jan 28, 2026

[Refactor] Email Rendering Error Logging Changes #1140

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

capture freestyle error #969

capture freestyle error #969

Uh oh!

BilalG1 commented Oct 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Oct 22, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 22, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

capture freestyle error #969

capture freestyle error #969

Uh oh!

Conversation

BilalG1 commented Oct 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Greptile Overview

Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BilalG1 commented Oct 22, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Oct 22, 2025 •

edited

Loading

coderabbitai bot commented Oct 22, 2025 •

edited

Loading