Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update example-airflow-incluster.yaml with kubernetes executors configuration#522

Closed
PaulienVa wants to merge 0 commit into
stackabletech:mainfrom
PaulienVa:patch-1
Closed

Update example-airflow-incluster.yaml with kubernetes executors configuration#522
PaulienVa wants to merge 0 commit into
stackabletech:mainfrom
PaulienVa:patch-1

Conversation

@PaulienVa
Copy link
Copy Markdown
Contributor

@PaulienVa PaulienVa commented Oct 28, 2024 •
edited
Loading

Description

The configuration for the usages of custom resources in a kubernetes cluster was not complete, the kubernetesExecutors configuration with an envOverride is also needed. (in that case the CeleryExecutors is not)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer requested a review from adwk67 October 28, 2024 12:40
@adwk67
Copy link
Copy Markdown
Member

adwk67 commented Oct 28, 2024 •
edited
Loading

@PaulienVa thank you for opening this! I think an inline comment would suffice, though, as the workers can only be one of celery- or kubernetesExecutors and so the example as written would not be deployable. Something like:

celeryExecutors: # the same can be applied to kubernetesExecutors if used

Also, we block merging into release branches at the moment, so this PR should be made against main (see the failing Stackable Build Pipeline check below.

@PaulienVa PaulienVa changed the base branch from release-24.7 to main October 28, 2024 13:16
@PaulienVa
Copy link
Copy Markdown
Contributor Author

PaulienVa commented Oct 28, 2024

@adwk67 I changed the target branch in case you want to merge. I thought I would be good to document the kubernetesExecutors explicitely as the syntax of the yaml is slightly different than the celeryExecutors

@adwk67
Copy link
Copy Markdown
Member

adwk67 commented Oct 28, 2024

Can you rebase or merge main into your branch and resolve the conflicts, so that this PR contains only your changes? At the moment this PR still contains changes made in the release branch.

@PaulienVa PaulienVa closed this Oct 28, 2024
@PaulienVa
Copy link
Copy Markdown
Contributor Author

PaulienVa commented Oct 28, 2024 •
edited
Loading

@adwk67 hereby a cleaner PR: #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67 adwk67 Awaiting requested review from adwk67

Assignees

No one assigned

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaulienVa @adwk67