Codestin Search App

soenkeliebau · 2022-08-11T15:36:53Z

Currenty we cannot upgrade NiFi without manual intervention, as NiFi can't run with mixed versions in a cluster and StateFulSets do not have an upgrade policy of "full".

This PR adds tracking of the deployed NiFi version to the status of the NiFi object and evaluates if a reconciliation signifies a change of the deployed version. If this is recognized a full stop of the cluster is performed and only then the updated version rolled out.

fixes #238

Signed-off-by: Sönke Liebau [email protected]

Description

Please add a description here. This will become the commit message of the merge request later.

Review Checklist

Code contains useful comments
CRD change approved (or not applicable)
(Integration-)Test cases added (or not applicable)
Documentation added (or not applicable)
Changelog updated (or not applicable)
Cargo.toml only contains references to git tags (not specific commits or branches)
Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

…Fi version. fixes #238 Signed-off-by: Sönke Liebau <[email protected]>

Signed-off-by: Sönke Liebau <[email protected]>

This reverts commit 1d0e0a5.

Signed-off-by: Sönke Liebau <[email protected]>

maltesander

Tested and works fine (only one zookeeper version)!

--- PASS: kuttl (348.76s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/upgrade_zookeeper-3.8.0-stackable0.7.0_nifi_old-1.15.0-stackable0.4.0_nifi_new-1.16.3-stackable0.1.0 (164.70s)
        --- PASS: kuttl/harness/upgrade_zookeeper-3.8.0-stackable0.7.0_nifi_old-1.16.0-stackable0.1.0_nifi_new-1.16.3-stackable0.1.0 (182.84s)
PASS

Some issues/questions:

The (old) reporting task job is not getting deleted (missing in orphaned resources) after update
Does it make sense to use one of the python tests (e.g. test_nifi.py to check for registered nodes) in the upgrade tests?
Do we need a flow-file/data test? In terms of are the versions and their data really compatible? We do that e.g. in Kafka.
Does it make sense to emit the log messages as events ("Cluster has been stopped for a restart, will scale back up.")?

soenkeliebau · 2022-08-12T20:38:41Z

The (old) reporting task job is not getting deleted (missing in orphaned resources) after update

We need to have a look at that, yes. I noticed this as well, but figured this will mostly be an issue during testing, when we trigger the upgrade before the job for the old version is finished.
For the tests we could solve it "preliminarily" by adding a condition to wait for the job to succeed in the install NiFi step I think..

Does it make sense to use one of the python tests (e.g. test_nifi.py to check for registered nodes) in the upgrade tests?

It absolutely does, I'll look into this when I get back. Or if someone else wants to pick this up in the meantime, please do feel free to!

Do we need a flow-file/data test? In terms of are the versions and their data really compatible? We do that e.g. in Kafka.

We should have that, yes.

Does it make sense to emit the log messages as events ("Cluster has been stopped for a restart, will scale back up.")?

It does!

Co-authored-by: Malte Sander <[email protected]>

# Conflicts: # deploy/crd/nificluster.crd.yaml # docs/modules/ROOT/pages/usage.adoc # rust/crd/src/authentication.rs # rust/crd/src/lib.rs

Signed-off-by: Sönke Liebau <[email protected]>

razvan · 2022-09-19T14:16:10Z

Test results: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/7/ 🟢

maltesander

Just minor things and a question:
Do we want to try loading a flow template / data in general?

@sbernauer used a job to ingest the flow: https://github.com/stackabletech/stackablectl/blob/main/demos/nifi-kafka-druid-water-level-data/create-nifi-ingestion-job.yaml and https://github.com/stackabletech/stackablectl/blob/main/demos/nifi-kafka-druid-water-level-data/IngestWaterLevelsToKafka.xml.
We could check in the up/downgrade that this is still available / working after the restart (a much easier flow)?

Co-authored-by: Malte Sander <[email protected]>

razvan · 2022-09-22T16:22:09Z

🟢 CI test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/8/

maltesander

Very nice! LGTM.

razvan · 2022-09-23T11:33:48Z

bors merge

…Fi version (#323) Currenty we cannot upgrade NiFi without manual intervention, as NiFi can't run with mixed versions in a cluster and StateFulSets do not have an upgrade policy of "full". This PR adds tracking of the deployed NiFi version to the status of the NiFi object and evaluates if a reconciliation signifies a change of the deployed version. If this is recognized a full stop of the cluster is performed and only then the updated version rolled out. fixes #238 Signed-off-by: Sönke Liebau <[email protected]> # Description *Please add a description here. This will become the commit message of the merge request later.* Co-authored-by: Sönke Liebau <[email protected]> Co-authored-by: Razvan-Daniel Mihai <[email protected]>

bors · 2022-09-23T11:45:43Z

Pull request successfully merged into main.

Build succeeded:

All tests passed

Forgot to do it in #323

Added code to perform full cluster stop when changing the deployed Ni…

1c8d33e

…Fi version. fixes #238 Signed-off-by: Sönke Liebau <[email protected]>

soenkeliebau requested a review from a team August 11, 2022 15:37

soenkeliebau added 4 commits August 11, 2022 17:45

Linter

1d0e0a5

Signed-off-by: Sönke Liebau <[email protected]>

Revert "Linter"

d7b7a39

This reverts commit 1d0e0a5.

Yaml Lint

9819048

Signed-off-by: Sönke Liebau <[email protected]>

Linter

470907e

Signed-off-by: Sönke Liebau <[email protected]>

maltesander self-assigned this Aug 12, 2022

maltesander requested changes Aug 12, 2022

View reviewed changes

Comment thread rust/operator-binary/src/controller.rs Outdated

Comment thread rust/operator-binary/src/controller.rs Outdated

Comment thread rust/operator-binary/src/controller.rs Outdated

Comment thread tests/templates/kuttl/upgrade/00-assert.yaml Outdated

soenkeliebau and others added 5 commits September 9, 2022 12:04

Apply suggestions from code review by @maltesander

45f08f0

Co-authored-by: Malte Sander <[email protected]>

Merge branch 'main' into feat/update

d5ad245

# Conflicts: # deploy/crd/nificluster.crd.yaml # docs/modules/ROOT/pages/usage.adoc # rust/crd/src/authentication.rs # rust/crd/src/lib.rs

Added more test steps to not reuse test container.

4130558

Signed-off-by: Sönke Liebau <[email protected]>

Merge branch 'main' into feat/update

cf28057

Merge remote-tracking branch 'origin/feat/update' into feat/update

f557fbb

razvan self-requested a review September 19, 2022 09:03

razvan added 3 commits September 19, 2022 15:48

Streamline kuttl upgrade test.

8931388

Merge branch 'main' into feat/update

fe69026

Use the testing-tools image everywhere.

2c620bd

razvan approved these changes Sep 20, 2022

View reviewed changes

maltesander self-requested a review September 20, 2022 07:11

maltesander requested changes Sep 20, 2022

View reviewed changes

razvan and others added 3 commits September 20, 2022 15:37

Update rust/operator-binary/src/controller.rs

da23484

Co-authored-by: Malte Sander <[email protected]>

Implement review feedback

73a8490

Fix typo

f716c6c

razvan mentioned this pull request Sep 21, 2022

[Merged by Bors] - Use the testing-tools image #349

Closed

7 tasks

razvan added 2 commits September 22, 2022 14:30

main merge

8d5650b

Expand upgrade test with sample flow.

1f6dbe1

razvan requested a review from maltesander September 22, 2022 16:22

maltesander approved these changes Sep 23, 2022

View reviewed changes

bors Bot changed the title ~~Added code to perform full cluster stop when changing the deployed NiFi version~~ [Merged by Bors] - Added code to perform full cluster stop when changing the deployed NiFi version Sep 23, 2022

bors Bot closed this Sep 23, 2022

bors Bot deleted the feat/update branch September 23, 2022 11:45

razvan mentioned this pull request Sep 23, 2022

[Merged by Bors] - Update the CHANGELOG. #350

Closed

bors Bot pushed a commit that referenced this pull request Sep 26, 2022

Update the CHANGELOG. (#350)

250e533

Forgot to do it in #323

Uh oh!

Conversation

soenkeliebau commented Aug 11, 2022

Description

Review Checklist

Uh oh!

maltesander left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

soenkeliebau commented Aug 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

razvan commented Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maltesander left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

razvan commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maltesander left a comment

Choose a reason for hiding this comment

Uh oh!

razvan commented Sep 23, 2022

Uh oh!

bors Bot commented Sep 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

soenkeliebau commented Aug 12, 2022 •

edited

Loading

razvan commented Sep 19, 2022 •

edited

Loading

maltesander left a comment •

edited

Loading

razvan commented Sep 22, 2022 •

edited

Loading