Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Merged by Bors] - Add support for Google sheets connector#337

Closed
sbernauer wants to merge 6 commits into
mainfrom
google-sheets-connector
Closed

[Merged by Bors] - Add support for Google sheets connector#337
sbernauer wants to merge 6 commits into
mainfrom
google-sheets-connector

Conversation

@sbernauer

@sbernauer sbernauer commented Nov 7, 2022 •
edited by adwk67
Loading

Copy link
Copy Markdown
Member

Closes #339

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer changed the title Intial support for Google Sheets connector Add support for Google sheets connector Nov 8, 2022
@sbernauer sbernauer marked this pull request as ready for review November 8, 2022 11:22
adwk67
adwk67 approved these changes Nov 11, 2022
View reviewed changes

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % missing-trino-link

Comment thread docs/modules/ROOT/pages/concepts.adoc
Comment thread rust/operator-binary/src/catalog/config.rs
@sbernauer sbernauer requested a review from adwk67 November 14, 2022 09:36
@sbernauer

sbernauer commented Nov 14, 2022

Copy link
Copy Markdown
Member Author

bors r+

bors Bot pushed a commit that referenced this pull request Nov 14, 2022
@sbernauer
Add support for Google sheets connector (#337)
e2d859b 
Closes #339
@bors

bors Bot commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Pull request successfully merged into main.

Build succeeded:

@bors bors Bot changed the title Add support for Google sheets connector [Merged by Bors] - Add support for Google sheets connector Nov 14, 2022
@bors bors Bot closed this Nov 14, 2022
@bors bors Bot deleted the google-sheets-connector branch November 14, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Google Sheets connector

2 participants

@sbernauer @adwk67