Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Assertion violation introduced by #81 #103

Closed
ghost opened this issue Nov 25, 2016 · 4 comments
Closed

Assertion violation introduced by #81 #103

ghost opened this issue Nov 25, 2016 · 4 comments
Labels
2.7-slp bug minor stackless python
Milestone
2.7.13-slp

Comments

@ghost
Copy link

ghost commented Nov 25, 2016

Originally reported by: Anselm Kruis (Bitbucket: akruis, GitHub: akruis)

The fix for #81 (1388a20039578) introduced an invalid assertion. I discovered it during tests of 3.4-slp, but all other versions are affected too. Fortunately it is trivial to fix.

The failure message is:
Stackless/core/stacklesseval.c:556: slp_kill_tasks_with_stacks: Assertion `t->cstate == cs' failed
@ghost
Copy link
Author

ghost commented Nov 25, 2016

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):

Test case and fix is in changeset

  • 2.7-slp: a2f6602
  • 3.3-slp: f2725cf
  • 3.4-slp: a5c6bdf
  • default-slp: 328bc69

@ghost
Copy link
Author

ghost commented Nov 25, 2016

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):

Unfortunately I have to reopen this issue, because I found another incarnation of this problem Assertion failed: t->cstate == cs, file ..\Stackless\core\stacklesseval.c, line 459.

Unfortunately this assertion violation reveals a serious problem in slp_kill_tasks_with_stacks(). When I reworked this function (issue #81), I didn't take deeply nested tasklets into account.

@ghost
Copy link
Author

ghost commented Nov 25, 2016

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):

I just created pull request #21 for 2.7-slp.

@ghost
Copy link
Author

ghost commented Dec 12, 2016

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):

After two weeks of inactivity I decided to manually merge pull request #21, because it blocked a fix for issue #105.

Changesets:

  • 2.7-slp: 130a60b
  • 3.3-slp: 667cf50
  • 3.4-slp: 510ae88
  • default-slp: f5710d9

@ghost ghost added this to the 2.7.13-slp milestone Sep 24, 2017
@ghost ghost closed this as completed Sep 24, 2017
akruis pushed a commit that referenced this issue Mar 3, 2018
@Carreau @warsaw
bpo-29546: Improve from-import error message with location (#103)
1bc1564 
bpo-29546: Improve from-import error message with location
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
2.7-slp bug minor stackless python
Projects
None yet
Milestone
2.7.13-slp
Development

No branches or pull requests
0 participants