fix: Make URL and Prefix mutually exclusive #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you passed both at the same time `prefix` would override the URL, so for example if you said `--url=console.dev.stacklet.dev` but then also said `--prefix=dev` it would ignore url and send you to `console.dev.stacklet.io` which is confusing.
|
Looks like there is some overlap with the PR here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Make URL and Prefix mutually exclusive. Don't return exit code zero if things failed.
why
If you passed both at the same time
prefixwould override the URL, so for example if you said--url=console.dev.stacklet.devbut then also said--prefix=devit would ignore url and send you toconsole.dev.stacklet.iowhich is confusing.testing
Added many tests
docs
The CLI has
--help