[6.x] Replicator focus state improvements #13354
Merged
+40
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line on a container when it has focus-within
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a load of focus state improvements for replicators (and bard sets), and closes #13295.
I fixed an issue where some buttons, such as
toggle fullscreen mode, were receiving focus states inside sets when they were collapsed.Replicator "plus" buttons are now focusable
The focus state of replicator "bars" is improved so it looks neater
Replicator Bar Focus State Before
Replicator Bar Focus State After
Bard Focus State Before
When a Bard set is focused, the badge is highlighted. This looks nice, but I don't think it's quite as obvious that the whole set will collapse if you tap
enterBard Focus State After
When a Bard set is focused, the whole top section is highlighted. It's more obvious that the set will collapse if you interact with the focus state. This is also consistent with replicator field focus states.