[6.x] Remove vendor from namespace if it exists#14100
Open
indykoning wants to merge 1 commit intostatamic:6.xfrom
Open
[6.x] Remove vendor from namespace if it exists#14100indykoning wants to merge 1 commit intostatamic:6.xfrom
indykoning wants to merge 1 commit intostatamic:6.xfrom
Conversation
Member
|
I'm hesitant to just chop off parts of a string. Seems weird that the word |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run into this issue when using https://github.com/statamic-rad-pack/runway
Th blueprint edit page does have the correct url and handles set.
Once the save button is used a 404 gets thrown. Why?
Because the url is like follows
/cp/fields/blueprints/vendor.runway/categoryMeaning it will look for a blueprint with the handle
vendor.runway::categoryBringing it to code, calling
Blueprint::find('runway::category')->namespace()returnsvendor.runway(the full path to the file is
/resources/blueprints/vendor/runway/category.yaml)I'm not sure wether this should be moved to runway, but i did not seem to see a way for runway to add a path to remove to resolve the namespace.