Look for all accepted encodings for precompressed files but keeping the quality ordering #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 4 of 5 files. Overall, the semantic diff is 51% smaller than the GitHub diff.
|
1 task
joseluisq
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of only looking for a precompressed file matching the preferred encoding, I check for all accepted encodings.
Related Issue
#438
Motivation and Context
Crome accepts brotli and brotli is generally superior to gzip, but Chrome always lists gzip first in the
Accept-Encodingheader.#438
How Has This Been Tested?
I created a new brotli compressed
index.html.brand created a test that acceptsdeflate, br. Because of this change theindex.html.brwill be returned, where previously no compressed file would be returned.Screenshots (if appropriate):