Re-enable Windows 7, 8, 8.1 builds support previously dropped in v2.31.0 #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since latest Rust 1.78.0 drops support Windows 7 support. See https://blog.rust-lang.org/2024/02/26/Windows-7.html We pin Rust to 1.77.2 for the following Windows targets: - x86_64-pc-windows-msvc - i686-pc-windows-msvc - x86_64-pc-windows-gnu aarch64-pc-windows-msvc (a.k.a. Windows ARM64) will continue using the latest stable Rust available. NOTES: Microsoft stopped support for Windows 7 (also for extended users in 2023). But at the moment we don't know how long we should keep supporting this unmaintained platform. However, keep in mind that we could reconsider bumping up the MSRV in future SWS versions when convenient, advising users accordingly. See https://learn.microsoft.com/en-us/lifecycle/products/windows-7
|
Review changes with SemanticDiff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds again support for the legacy Windows 7, 8, 8.1 previously removed in SWS
v2.31.0due to Rust also dropped support in 1.78.0.Now, we pin Rust to
1.77.2for the following Windows targets:x86_64-pc-windows-msvci686-pc-windows-msvcx86_64-pc-windows-gnuaarch64-pc-windows-msvc(a.k.a. Windows ARM64) will continue using the latest stable Rust available.Notes
Microsoft stopped support for Windows 7 in 2020 (2023 for extended users).
But at the moment, we don't know how long we will keep supporting this unmaintained platform.
However, keep in mind that we could reconsider bumping up the MSRV in future SWS versions when convenient, advising users accordingly.
Related Issue
Motivation and Context
https://github.com/orgs/static-web-server/discussions/445#discussioncomment-9495097
How Has This Been Tested?
Screenshots (if appropriate):