Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove redundant async function signatures #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

joseluisq
Copy link
Collaborator

@joseluisq joseluisq commented Jun 26, 2024

Description

This PR improves the code signature of some async functions and makes them sync to communicate better the function's intention.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

@joseluisq joseluisq added enhancement New feature or request v2 v2 release codebase Related to the project's source code labels Jun 26, 2024
Copy link

semanticdiff-com bot commented Jun 26, 2024

Review changes with SemanticDiff.

Analyzed 9 of 9 files.

Overall, the semantic diff is 51% smaller than the GitHub diff.

Filename Status
✔️ src/compression_static.rs 15.28% smaller
✔️ src/control_headers.rs 5.09% smaller
✔️ src/directory_listing.rs 47.31% smaller
✔️ src/https_redirect.rs 16.67% smaller
✔️ src/response.rs 16.67% smaller
✔️ src/server.rs 75.0% smaller
✔️ src/static_files.rs 63.81% smaller
✔️ tests/cors.rs 5.41% smaller
✔️ tests/settings.rs 5.2% smaller

@joseluisq joseluisq changed the title Remove redundant async functions Remove redundant async function signatures Jun 26, 2024
@joseluisq joseluisq merged commit 4c805d6 into master Jun 26, 2024
39 checks passed
@joseluisq joseluisq deleted the clean-up-redundant-async-functions branch June 26, 2024 23:35
@joseluisq joseluisq added this to the v2.332.0 milestone Jun 26, 2024
@joseluisq joseluisq modified the milestone: v2.32.1 Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codebase Related to the project's source code enhancement New feature or request v2 v2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant