Review changes with  

Changed Files

File	Status
src/settings/mod.rs	46% smaller
docs/content/features/url-redirects.md	Unsupported file format
tests/fixtures/toml/redirects.toml	Unsupported file format
tests/redirects.rs	0% smaller

@joseluisq

With literal_seprator(true) the following test cases don't work as before anymore:

# Glob groups 5
[[advanced.redirects]]
source = "**/{*}.{jpg,jpeg}"
destination = "http://localhost/new-images/$2.$3"
kind = 302

# Glob groups 6
[[advanced.redirects]]
source = "**/{*}.{ttf,otf,woff}"
destination = "http://localhost/new-fonts/$2.woff"
kind = 302

For instance:

thread 'tests::redirects_glob_groups_5' panicked at tests/redirects.rs:158:17:
assertion `left == right` failed
  left: "http://localhost/new-images/avatar.jpeg"
 right: "http://localhost/new-images/images/avatar.jpeg"

The additional path is now contained in $1 from **. It doesn't seem that it be appropriate to change the assertion of the tests. Maybe with also adding additional paths into the requested URL to test the **?

The additional path is now contained in $1 from **. It doesn't seem that it be appropriate to change the assertion of the tests. Maybe with also adding additional paths into the requested URL to test the **?

You can try that. I wonder if we can take advantage of this PR and add a few more tests tackling other common cases. E.g. double/single *, ranges, etc.

--

Additionally, since literal_seprator(true) will be a breaking change for the sake of consistency, we will need also to inform users properly via the Redirects page.

Aside, I'm still wondering why globset does not go with literal_seprator(true) by default.

I wonder if we can take advantage of this PR and add a few more tests tackling other common cases. E.g. double/single *, ranges, etc.

Sure. Can you add more detail what you mean with those examples? It’s not totally clear to me.

Sure. Can you add more detail what you mean with those examples? It’s not totally clear to me.

I just meant to add a couple of other unit test cases (not just /{*}/{*}/) with group combinations using ranges, for example /[0-9]/[a-z]/{*}/, /crop-[^0-9]/*.{jpg,jpeg} or another.

I fixed the tests.

Additionally, since literal_seprator(true) will be a breaking change for the sake of consistency, we will need also to inform users properly via the Redirects page.

Added an extra admonition warning about this. Happy for any alternative suggestions on the text etc. Is the changelog automatically generated? Otherwise we would need to add it there too.

Aside, I'm still wondering why globset does not go with literal_seprator(true) by default.

I wonder the same. So I asked here: BurntSushi/ripgrep#2940

Regarding the other tests. If you're ok with it I would do this in a separate PR. There are also some warnings that mkdocs reports that would be good to address.

Is the changelog automatically generated? Otherwise we would need to add it there too.

The changelog is not automatically generated but we will mention it in the upcoming release for sure.

Regarding the other tests. If you're ok with it I would do this in a separate PR. There are also some warnings that mkdocs reports that would be good to address.

That makes sense, take your time. The current PR though looks fine to me.

I'm also thinking that the URL Rewrites feature should follow the same approach. PR is welcome.

I'm also thinking that the URL Rewrites feature should follow the same approach. PR is welcome.

Makes sense. Is this required for the next release?

Makes sense. Is this required for the next release?

No. It isn't, but I have plans to release v2.34.0 on the weekend but take your time.
If you would to work on that and want it on the next release let me know.

Btw feel free to join Discord.