Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve fallback page path checking and logging #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

joseluisq
Copy link
Collaborator

@joseluisq joseluisq commented Feb 2, 2025

Description

This PR improves the fallback page feature by checking if the path exists, if not then it logs a debug entry.
Additionally, the fallback feature page and command descriptions are clarified.

Related Issue

Motivation and Context

It resolves #519

How Has This Been Tested?

Screenshots (if appropriate):

@joseluisq joseluisq added enhancement New feature or request v2 v2 release labels Feb 2, 2025
Copy link

semanticdiff-com bot commented Feb 2, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/settings/cli.rs  39% smaller
  src/fallback_page.rs  28% smaller
  docs/content/configuration/command-line-arguments.md Unsupported file format
  docs/content/configuration/environment-variables.md Unsupported file format
  docs/content/features/error-pages.md Unsupported file format

@joseluisq joseluisq changed the title Check fallback page path exist and add log debug entry if not Improve fallback page path checking and logging Feb 2, 2025
@joseluisq joseluisq marked this pull request as ready for review February 3, 2025 17:09
@joseluisq joseluisq merged commit 8fa9cda into master Feb 3, 2025
25 of 34 checks passed
@joseluisq joseluisq deleted the improve-fallback-page-feature branch February 3, 2025 17:23
@joseluisq joseluisq added this to the v2.36.0 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2 v2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fallback page not enabled
1 participant