Fix Matplotlib deprecation of loc as a positional keyword in legend functions
#8429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the 3.6 release Matplotlib depreciated using `loc` as a positional keyword for the figure.legend function, making it a keyword only function starting from Matplotlib 3.8. This commit adds the `loc` keyword to the figure.legend and figlegend functions to resolve the depreciation warning and prepare for future Matplotlib versions.
|
Unrelated failure. Thanks for the future proofing. |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the 3.6 release Matplotlib deprecated using
locas a positional keyword for the figure.legend function, making it a keyword only function starting from Matplotlib 3.8.This commit adds the
lockeyword to the figure.legend and figlegend functions to resolve the depreciation warning and prepare for future Matplotlib versions.The
lockeyword is added in 23 places over 6 files, including functions, docs and tests. I think I caught all occurrences, but double checking would be appreciated. It removes all 21 MatplotlibDeprecationWarnings caught by the Azure CI (before, after).NumPy's guide.