You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We cannot delete the part that raises the warning.
There are still other keywords that users might use and are not allowed.
Without the warning, the fit method quietly ignores the extra keywords, even if they are, for example, a misspelled version of an allowed keyword.
We can raise NotImplementedError for cov_type, but it should not removed the other warnings.
e.g. add cov_type to allowed keywords, but with a code commend like # keyword handled explicitly
@josef-pkt I've updated the changes. Please let me know if they need further improvement.
I also had a small suggestion, maybe adding a pre-commit run step could help contributors run quick local checks before pushing. If you think this could be useful, I can open an issue for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thank you!