BUG: raise error for invalid endog input in emplike.DescStat#9747
Open
vkverma9534 wants to merge 4 commits intostatsmodels:mainfrom
Open
BUG: raise error for invalid endog input in emplike.DescStat#9747vkverma9534 wants to merge 4 commits intostatsmodels:mainfrom
vkverma9534 wants to merge 4 commits intostatsmodels:mainfrom
Conversation
This PR adds basic input validation to emplike.DescStat to ensure that the input data (endog) is a non-empty 1D or 2D array. Previously, scalar, empty, or higher-dimensional inputs could be silently reshaped or lead to unclear errors later in the computation. The new validation raises a clear ValueError early, improving robustness and user feedback. A regression test is included to cover these invalid input cases. Existing behavior for valid inputs is unchanged.
Contributor
Author
|
Hi, I’m seeing a Pyodide CI failure on this PR after adding early input validation in emplike.DescStat. Standard CI passes, but Pyodide fails during statsmodels.test(). Before iterating further, could you advise on the expected handling of scalar endog here, and whether there’s a preferred Pyodide-safe normalization pattern? Happy to adjust based on guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic input validation to emplike.DescStat to ensure that the input data (endog) is a non-empty 1D or 2D array.
Previously, scalar, empty, or higher-dimensional inputs could be silently reshaped or lead to unclear errors later in the computation. The new validation raises a clear ValueError early, improving robustness and user feedback.
A regression test is included to cover these invalid input cases. Existing behavior for valid inputs is unchanged.