fix: add informative error message when Hessian inversion fails in fit_regularized#9757
Open
dhruvildarji wants to merge 1 commit intostatsmodels:mainfrom
Open
Conversation
…t_regularized When fit_regularized encounters a singular Hessian matrix during covariance parameter estimation in cov_params_func_l1, the previous behavior was to propagate a cryptic LinAlgError. This commit wraps the np.linalg.inv call with a try/except that re-raises with a descriptive message explaining the likely causes (perfect separation, quasi-perfect separation, multicollinearity) and actionable remedies (check data for separation, remove redundant predictors, or increase regularization penalty alpha). Fixes statsmodels#2305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2305.
When
fit_regularizedis called on discrete models (e.g., Logit, Probit, MNLogit, Poisson), the covariance parameter estimation incov_params_func_l1callsnp.linalg.inv(-H_restricted)to invert the restricted Hessian matrix. If the data has perfect or quasi-perfect separation — where a predictor (or combination of predictors) perfectly predicts the outcome — the Hessian becomes singular and this inversion fails with a crypticLinAlgError: Singular matrixmessage that gives users no guidance on the root cause.Changes
statsmodels/discrete/discrete_model.pyDiscreteModel.cov_params_func_l1np.linalg.inv(-H_restricted)call in atry/except np.linalg.LinAlgErrorblockBefore
After
Test plan
fit_regularizedfit_regularizedusage (non-singular Hessian) is unaffectedpython -m pytest statsmodels/discrete/tests/ -x -q