Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: address commit comments for commit 3badc70 (issue #10662)#10669

Closed
MANDEep22332 wants to merge 1 commit intostdlib-js:developfrom
MANDEep22332:chore/address-3badc70-new
Closed

chore: address commit comments for commit 3badc70 (issue #10662)#10669
MANDEep22332 wants to merge 1 commit intostdlib-js:developfrom
MANDEep22332:chore/address-3badc70-new

Conversation

@MANDEep22332
Copy link

@MANDEep22332 MANDEep22332 commented Mar 3, 2026 •
edited
Loading

Resolves #10662

Description

fix of address commit comments for commit 3babc70 and ::factory

What is the purpose of this pull request?

This pull request:

  • {{TODO: Updated the benchmark label from %s:factory to %s::factory in the Pareto Type I quantile benchmark to follow stdlib’s export naming conventions.}}

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Mar 3, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 3, 2026

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 3, 2026
@kgryte
Copy link
Member

kgryte commented Mar 3, 2026

Ref: #10665

@kgryte kgryte added autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. labels Mar 3, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 3, 2026

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 3badc70)

3 participants

@MANDEep22332 @stdlib-bot @kgryte