fix(ci): make Slack notifications non-fatal in test_bundles workflow … #9443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…template
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
kgryte
reviewed
Jan 2, 2026
Member
kgryte
left a comment
There was a problem hiding this comment.
Thank you for this PR; however, in this case, the changes are not desired. The reasons are twofold:
- We recently migrated to pushing messages to Zulip.
- We would likely not want to ignore CI failing to send messages. Why? Because if we did, how will we know that the workflow is failing to send messages? If we always skip on an error, this failure could be missed entirely, and as messages would not be sent to Zulip, we'd be unaware that anything is amiss.
Thanks again for your interest in stdlib, and we look forward to your future contributions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…template
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
#8864.
Description
This pull request:
test_bundlesGitHub Actions workflow template to ensure that Slack notification steps do not cause CI failures when Slack configuration is missing or misconfigured.The change applies only to the workflow template, so it affects newly generated workflows without modifying existing ones.
In forks and local testing environments, Slack secrets are often unavailable.
Currently, failures in the Slack notification step can cause otherwise successful CI jobs to fail.
Related Issues
This pull request has the following related issues:
randomrepository #8864Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers