Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 12, 2019. It is now read-only.

increment seqnumber#87

Merged
bartekn merged 3 commits into
masterfrom
increment-seqnumber
Dec 29, 2017
Merged

increment seqnumber#87
bartekn merged 3 commits into
masterfrom
increment-seqnumber

Conversation

@poliha

@poliha poliha commented Dec 28, 2017

Copy link
Copy Markdown
Contributor

closes #86

@bartekn

bartekn commented Dec 28, 2017

Copy link
Copy Markdown
Contributor

Not sure if that's what we want. We should probably update the docs to explain that the sequence_number is the one that will be used in a transaction.

@poliha

poliha commented Dec 28, 2017

Copy link
Copy Markdown
Contributor Author

Yes we should update the docs, but we also want bridge to work if no sequence number is passed to /builder endpoint. At the moment, this won't give a valid transaction xdr to submit to the network.

@bartekn

bartekn commented Dec 28, 2017

Copy link
Copy Markdown
Contributor

OK, then I think we should only increment sequence number if it was loaded from Horizon. Otherwise, it shouldn't be changed.

@bartekn bartekn merged commit 598b5b3 into master Dec 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sequence number is not incremented in /builder

2 participants