Optimized (and improved support for Unity 5 to 2022)#1
Closed
saurondark22 wants to merge 1 commit into
Closed
Conversation
what I did: - Rearranged methods. - Added support for latest unity 5. (just tested unity 5 and unity 2022) - Optimized scroll view to update thumbnails, buttons and labels only when element visible in view. - Layout changes inside scroll view for maximum info visibility per element" know issue: - scroll down to last element and resize window will throw some error on console.
|
Had to do this for it to compile. Can confirm the scroll view better performances ! #if UNITY_2021 || UNITY_2020 //L.305
for (int i = 0; i < 3; i++) //TODO Get secondaries array length instead
{
if (tSpriteRenderer.sprite.getSecondaryTexture(i) == null) continue;
#if UNITY_2021_3
var tSpriteSecondaryTextureDetail = GetTextureDetail(tSpriteRenderer.sprite.getSecondaryTexture(i));
#else
var tSpriteSecondaryTextureDetail = GetTextureDetail(tSpriteRenderer.sprite.getSecondaryTexture(i), renderer);
#endif
if (!ActiveTextures.Contains(tSpriteSecondaryTextureDetail)) {
ActiveTextures.Add(tSpriteSecondaryTextureDetail);
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what I did:
know issue: