Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Complete event name & dispatcher in EventDispatcherDebugCommand #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

GromNaN
Copy link

@GromNaN GromNaN commented Nov 28, 2021

Hi @stephenkhoo. Here is how I would do the completion for the debug:event command.
It starts from your PR symfony#43859.

nicolas-grekas and others added 30 commits November 13, 2021 12:08
…in the description (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[ErrorHandler] fix parsing ``@param`` with dollars in the description

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony#43936
| License       | MIT
| Doc PR        | -

Commits
-------

8046b3b [ErrorHandler] fix parsing ``@param`` with dollars in the description
This PR was merged into the 4.4 branch.

Discussion
----------

Fix CI by removing ext-mongodb

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

ext-mongodb [is broken](https://github.com/symfony/symfony/runs/4198337700) on PHP 8.1, and makes installing PHP extra slow anyway.

Commits
-------

5232197 Fix CI by removing ext-mongodb
* 4.4:
  Fix CI by removing ext-mongodb
  Fix FlattenException::setPrevious argument typing
* 5.3:
  Fix CI by removing ext-mongodb
  Fix FlattenException::setPrevious argument typing
…rings (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[Yaml] don't try to replace references in quoted strings

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony#44019
| License       | MIT
| Doc PR        |

Commits
-------

20555ad don't try to replace references in quoted strings
…c (BenMorel)

This PR was submitted for the 5.3 branch but it was merged into the 4.4 branch instead.

Discussion
----------

Fix DateIntervalToStringTransformer::transform() doc

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | -

`DateIntervalToStringTransformer::transform()` accepts `null`.

Commits
-------

71a9d15 Fix nullable parameter doc
* 4.4:
  Fix nullable parameter doc
  don't try to replace references in quoted strings
* 5.3:
  Fix nullable parameter doc
  don't try to replace references in quoted strings
This PR was merged into the 5.3 branch.

Discussion
----------

[Notifier] Fix package names

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Fix wrong package names (they do not follow our convention for package naming and that breaks their release process).

Commits
-------

8113ca9 [Notifier] Fix package name
This PR was merged into the 5.4 branch.

Discussion
----------

[Notifier] Fix package name

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Wrong package name.

Commits
-------

877da38 [Notifier] Fix package name
* 5.3:
  [Notifier] Fix package name
…ses that dont follow the convention (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[FrameworkBundle] deprecate notifier service aliases that dont follow the convention

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

b0bb93c [FrameworkBundle] deprecate notifier service aliases that dont follow the convention
This PR was merged into the 4.4 branch.

Discussion
----------

Never rely on dynamic properties

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

As described in https://wiki.php.net/rfc/deprecate_dynamic_properties

Commits
-------

aa4fb0c Never rely on dynamic properties
fabpot and others added 24 commits November 24, 2021 09:51
…ntracts >= 3 (Staormin)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[String] Add conflict with symfony/translation-contracts >= 3

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Got the following issue this morning in symfony 5.4-RC1 with php 8.1:
```
!!
!!  Fatal error: Declaration of Symfony\Component\String\Slugger\AsciiSlugger::getLocale() must be compatible with Symfony\Contracts\Translation\LocaleAwareInterface::getLocale(): string in /opt/project/vendor/symfony/string/Slugger/AsciiSlugger.php on line 93
!!  Symfony\Component\ErrorHandler\Error\FatalError {symfony#6153
!!    #message: "Compile Error: Declaration of Symfony\Component\String\Slugger\AsciiSlugger::getLocale() must be compatible with Symfony\Contracts\Translation\LocaleAwareInterface::getLocale(): string"
!!    #code: 0
!!    #file: "./vendor/symfony/string/Slugger/AsciiSlugger.php"
!!    #line: 93
!!    -error: array:4 [
!!      "type" => 64
!!      "message" => "Declaration of Symfony\Component\String\Slugger\AsciiSlugger::getLocale() must be compatible with Symfony\Contracts\Translation\LocaleAwareInterface::getLocale(): string"
!!      "file" => "/opt/project/vendor/symfony/string/Slugger/AsciiSlugger.php"
!!      "line" => 93
!!    ]
!!  }
!!
```
This PR fixed the error on my side.

Commits
-------

3b61236 [String] Add conflict with symfony/translation-contracts >= 3
This PR was merged into the 4.4 branch.

Discussion
----------

[appveyor] Bump apcu to 5.1.18

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

9ce61e1 [appveyor] Bump apcu to 5.1.18
* 4.4:
  [appveyor] Bump apcu to 5.1.18
  Bump Symfony version to 4.4.36
  Update VERSION for 4.4.35
  Update CONTRIBUTORS for 4.4.35
  Update CHANGELOG for 4.4.35
* 5.3:
  [appveyor] Bump apcu to 5.1.18
  Bump Symfony version to 5.3.13
  Update VERSION for 5.3.12
  Update CHANGELOG for 5.3.12
  Bump Symfony version to 4.4.36
  Update VERSION for 4.4.35
  Update CONTRIBUTORS for 4.4.35
  Update CHANGELOG for 4.4.35
…type" (dunglas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DoctrineBridge] Revert " add support for the JSON type"

This reverts commit 1e218c5.

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

As pointed out by @stof and @fancyweb on Slack, my patch is not in sync with Doctrine's code. Contrary to what is stated in the docs, Doctrine allows (almost) any PHP type to be stored as JSON. I also fixed the documentation of Doctrine: doctrine/dbal#5022

Commits
-------

a1e22dc Revert "[DoctrineBridge] add support for the JSON type"
This PR was merged into the 5.3 branch.

Discussion
----------

[Notifier] Fix AllMySms bridge body content

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony#44276
| License       | MIT

Fix the 1005 error code from AllMySms bridge with Notifier component

Commits
-------

376b3e5 [Notifier] Fix AllMySms bridge body content
…(nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[Serializer] fix support for lazy/unset properties

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony#44273 symfony#44283
| License       | MIT
| Doc PR        | -

This basically backports symfony#43469 into 4.4, which is the way to go to fix symfony#44273.
The code that exists to handle uninitialized properties is broken anyway (it was before the recent changes.)

Commits
-------

db043aa [Serializer] fix support for lazy/unset properties
This PR was merged into the 4.4 branch.

Discussion
----------

Fix redundant type casts

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | -
| Tickets       | -
| License       | MIT
| Doc PR        | -

Firstly, let's see if the CI is green as I expect it. I'll explain every change with a review comment.

Commits
-------

e724d5a Fix redundant type casts
…efault envs

- since environment variables are case-insensitive in Windows,
  all envs should be compared in case-insensitive manner
…ve manner to get default envs (stable-staple)

This PR was merged into the 4.4 branch.

Discussion
----------

[Process] intersect with getenv() in case-insensitive manner to get default envs

| Q             | A
| ------------- | ---
| Branch?       |  4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony#44260
| License       | MIT
| Doc PR        |

Since environment variables are case-insensitive in Windows, all envs should be compared in case-insensitive manner.

Commits
-------

d78bc24 [Process] intersect with getenv() in case-insensitive manner to get default envs
* 4.4:
  [Process] intersect with getenv() in case-insensitive manner to get default envs
  [Serializer] fix support for lazy/unset properties
  Fix redundant type casts
  Revert "[DoctrineBridge] add support for the JSON type"
* 5.3:
  [Process] intersect with getenv() in case-insensitive manner to get default envs
  [Serializer] fix support for lazy/unset properties
  Fix redundant type casts
  [Notifier] Fix AllMySms bridge body content
  Revert "[DoctrineBridge] add support for the JSON type"
@GromNaN GromNaN force-pushed the pull-43859 branch 2 times, most recently from 749b556 to 5b66228 Compare November 28, 2021 23:24
@GromNaN
Copy link
Author

GromNaN commented Nov 28, 2021

Closing as I rebased the branch.

@GromNaN GromNaN closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.