Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Resolve Doctrine proxies to real entity names#40

Merged
stephpy merged 4 commits into
stephpy:masterfrom
phansys:master
Nov 14, 2014
Merged

Resolve Doctrine proxies to real entity names#40
stephpy merged 4 commits into
stephpy:masterfrom
phansys:master

Conversation

@phansys
Copy link
Copy Markdown
Contributor

@phansys phansys commented Nov 12, 2014

Resolve Doctrine proxies to real entity names in order to generate proper identifiers for model.

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

…oper

identifiers for model.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT
@stephpy
Copy link
Copy Markdown
Owner

stephpy commented Nov 13, 2014

Hi,
Doctrine\Common has to be added to composer.json.

@phansys
Copy link
Copy Markdown
Contributor Author

phansys commented Nov 13, 2014

Hi @stephpy.
I was thinking the same, but I found that Doctrine\Common NS was already used in Entry.php.
BTW, I just update composer.json with this requirement.
Please, let me know if "~2.3" constraint is right for you.
Thank you.

@stephpy
Copy link
Copy Markdown
Owner

stephpy commented Nov 13, 2014

It seems ~2.2 suffice. Good catch for Entry.php, it's a mistake.

@phansys
Copy link
Copy Markdown
Contributor Author

phansys commented Nov 13, 2014

Perfect @stephpy.
Constraint updated.

stephpy added a commit that referenced this pull request Nov 14, 2014
Resolve Doctrine proxies to real entity names
@stephpy stephpy merged commit e3dc567 into stephpy:master Nov 14, 2014
@stephpy
Copy link
Copy Markdown
Owner

stephpy commented Nov 14, 2014

Thanks. :)

@phansys
Copy link
Copy Markdown
Contributor Author

phansys commented Nov 14, 2014

Thank you @stephpy.

@stephpy
Copy link
Copy Markdown
Owner

stephpy commented Nov 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants