Always use distinct when counting entries in KnpPager#45
Merged
Conversation
stephpy
added a commit
that referenced
this pull request
Aug 24, 2015
Always use distinct when counting entries in KnpPager
Owner
|
thanks |
Contributor
Author
|
I didn't think of it earlier, but actually it would be good to have a way to change the option, because someone might not want to use distinct for performance reasons. |
Owner
|
Yep, but the paginator count would be wrong, imo it's a good thing to keep distinct. For performances reasons, user can easily override pager class. :) |
Contributor
Author
|
👍 It was what actually I did to fix the issue, but this part also needs refactoring because I had to override using Compiler pass. Just setting my class in settings.yml does not work because of service dependancies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #43