Fix allowable cortex-m-rt versions #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous versions didn't set the 'links' cargo field, and risk being pulled together with newer ones.
adamgreig
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent Cargo from pulling in two different versions of cortex-m-rt, as happened in #602. This is done by requiring a cortex-m-rt version >=0.6.15, which was the first version where the
link=cortex-m-rtfield was set in Cargo.toml.The second fix is to clearly allow a cortex-m version >= 0.7.2, but still <0.8. I suspect that cargo would still allow newer versions to resolve version conflicts (as happened in #602), but I think it's better to be explicit about it.EDIT: just realized that the second fix doesn't make sense.