[stm32f7] Fix all timers registers #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6de9be7 to
9effa1a
Compare
9effa1a to
955553c
Compare
adamgreig
requested changes
Sep 2, 2021
There was a problem hiding this comment.
Thanks for this series of PRs! Good timing too as I'm close to releasing 0.14; I'll make sure these all get sorted first. I'll work through them in order though.
On the whole this one looks great, but there's a handful of bits I didn't understand or didn't seem right:
I'm not too worried about the names. You could put them inside |
Co-authored-by: Adam Greig <[email protected]>
Co-authored-by: Adam Greig <[email protected]>
|
Thanks for the updates, just the CCR5/6 query left I think. |
ff71736 to
545e6ff
Compare
adamgreig
approved these changes
Sep 6, 2021
bors bot
added a commit
that referenced
this pull request
Sep 9, 2021
612: [stm32f7] Fix SYSCFG registers r=adamgreig a=maximeborges Following #606, fix fields in SYSCFG for every F7 chips Co-authored-by: Maxime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix all the registers for every timers on every F7xx chips, based on the reference manual for those (
RM0431,RM0385andRM0410).I'd like to get suggestions for better names for the new common patches that I created, they don't seem to fit with the others but I'm not sure what would be the best way to name them.