devices/stm32l4r9.yaml: patch TIM3 and TIM4 #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's pretty neat, cool github action. |
adamgreig
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Thanks for this PR!
Ideally I guess TIM3 and TIM4 should not have the high fields copied from TIM2, but this is strictly better than the current setup where they just have a full 32-bit register, so let's get this in now and it could always be improved further later.
bors merge
bors bot
added a commit
that referenced
this pull request
Dec 7, 2021
669: devices/stm32l4r9.yaml: patch TIM3 and TIM4 r=adamgreig a=jspngh TIM3 and TIM4 work the same way in stm32l4r9 and stm32l4x6. Since `stm32l4x6.yaml` contains these `_copy` and `_derive` lines, they should also be added to this yaml file. Note that I've simply verified this empirically, with these lines added I can now use TIM3 and TIM4 to generate a PWM signal, and that I don't fully comprehend the SVD files yet. Co-authored-by: Jonas Spanoghe <[email protected]>
|
Build failed: |
|
Spurious network error bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIM3 and TIM4 work the same way in stm32l4r9 and stm32l4x6.
Since
stm32l4x6.yamlcontains these_copyand_derivelines, they should also be added to this yaml file.Note that I've simply verified this empirically, with these lines added I can now use TIM3 and TIM4 to generate a PWM signal,
and that I don't fully comprehend the SVD files yet.