-
Notifications
You must be signed in to change notification settings - Fork 246
Fix make html on macOS with python 3.8+ #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5abad0e
to
c3bd9c7
Compare
c3bd9c7
to
9749352
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good! Any reason it's still marked as a draft?
Only tiny comment is I like to stick to PEP8 which would complain about this missing space.
Co-authored-by: Adam Greig <[email protected]>
Fixed and marked for review at your convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
bors merge
Python3.8 and above changed the behavior of the multiprocessing module on macOS, resulting in variable scoping being tighter than on other platforms or versions.
As a simplified case, this code crashes on such a machine:
This patch passes in the relevant variable into the worker in a different style to fix. I've tested this on linux and Mac platforms for regressions.