Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add timers TIM23 and TIM24 to stm32h735 #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2022
Merged

Add timers TIM23 and TIM24 to stm32h735 #712

merged 1 commit into from
Apr 3, 2022

Conversation

omion
Copy link

@omion omion commented Apr 3, 2022

The SVD files in this repo don't include timers TIM23 and TIM24 for the RM0468-based chips (H730, H723, H725, H733, H735). There is an updated SVD that someone from STM posted here, which just adds the lines:

    <peripheral derivedFrom="TIM2">
      <name>TIM23</name>
      <baseAddress>0x4000E000</baseAddress>
      <interrupt>
        <name>TIM23</name>
        <description>TIM23 global interrupt</description>
        <value>161</value>
      </interrupt>
    </peripheral>
	<peripheral derivedFrom="TIM2">
      <name>TIM24</name>
      <baseAddress>0x4000E400</baseAddress>
      <interrupt>
        <name>TIM24</name>
        <description>TIM24 global interrupt</description>
        <value>162</value>
      </interrupt>
    </peripheral>

As far as I can tell, the changes I made to the yaml file do the same thing.

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Memory map comparison

@newAM newAM added the stm32h7 label Apr 3, 2022
richardeoin
richardeoin approved these changes Apr 3, 2022
View reviewed changes
Copy link
Member

@richardeoin richardeoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Checking in RM0468, TIM23 and TIM24 are 32-bit timers like TIM2. The only differences are the enumerations of AF1 and TISEL, but we (quite reasonably) don't have those here, so there's nothing else to change.

bors r+

@richardeoin
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Apr 3, 2022

Build succeeded:

@bors bors bot merged commit a9635c6 into stm32-rs:master Apr 3, 2022
@omion omion deleted the timers branch April 4, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardeoin richardeoin richardeoin approved these changes

Assignees
No one assigned
Labels
stm32h7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omion @richardeoin @newAM