Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jul 18, 2024

this avoids to add them to boards.txt if not needed.

cmake updated to get the default value from platform.txt.

/cc @massonal

This fixes this:
#2445 (comment)

@fpistm fpistm added the fix 🩹 Bug fix label Jul 18, 2024
@fpistm fpistm added this to the 2.8.1 milestone Jul 18, 2024
fpistm added 2 commits July 18, 2024 15:52
this avoids to add them to boards.txt if not needed.

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm force-pushed the default_vid_pid branch from d1eaf2f to 115d040 Compare July 18, 2024 13:54
@fpistm fpistm merged commit a42bcfe into stm32duino:main Jul 19, 2024
@fpistm fpistm deleted the default_vid_pid branch July 19, 2024 07:16
Copy link
Contributor

@massonal massonal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment at the top of platformtxt_filter is now outdated. It needs to mention this new policy wrt vid/pid.

@fpistm
Copy link
Member Author

fpistm commented Aug 12, 2024

The comment at the top of platformtxt_filter is now outdated. It needs to mention this new policy wrt vid/pid.

ecdf6af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Bug fix
Projects
Development

Successfully merging this pull request may close these issues.

2 participants