Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: ivy UseStoreon hook#21

Merged
irustm merged 1 commit into
storeon:masterfrom
valburyakov:feat-ivy-hook
Jul 11, 2019
Merged

feat: ivy UseStoreon hook#21
irustm merged 1 commit into
storeon:masterfrom
valburyakov:feat-ivy-hook

Conversation

@valburyakov

Copy link
Copy Markdown
Contributor

#15

Example of using Storeon with Ivy

@irustm

irustm commented Jul 11, 2019

Copy link
Copy Markdown
Member

Hey! Thanks for this PR.
please fix size-limit:

Size limit: 533 B
Package size: 536 B

@irustm

irustm commented Jul 11, 2019

Copy link
Copy Markdown
Member

and I think these hooks should go with the next tag.

@valburyakov

Copy link
Copy Markdown
Contributor Author

and I think these hooks should go with the next tag.

you mean publish lib with @next tag ?

@irustm

irustm commented Jul 11, 2019

Copy link
Copy Markdown
Member

I guess yeah, just need to update the demos, and write in readme that it's all an experiment

@irustm irustm merged commit 3f9a1a2 into storeon:master Jul 11, 2019
@irustm irustm mentioned this pull request Jul 11, 2019
@Svetomechc

Copy link
Copy Markdown
Contributor

So, this PR also makes it impossible to use @storeon/angular without Ivy as I understand? Just making sure that this was intended, @valburyakov?

I mean, even just using the service, not Ivy hooks, fails (in production mode, debug is fine):
image

@valburyakov

Copy link
Copy Markdown
Contributor Author

@Svetomechc You mean that even when you don't use ivy hook decorator prod build is failed with storeon ? If yes - that seems an issue.

@Svetomechc

Svetomechc commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

@valburyakov it builds fine but errors at runtime,
UPD: Nevermind, I think the error is caused by something in my local environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants