better outline #370
Closed
better outline #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase but I don't have push access to this branch so I can't merge. I decided to duplicate these changes to a different branch so that I can quickly merge the changes, hope thats ok. These changes will be merged on #382. Please when you make PR's enable the option to allow the maintainer to push changes. |
dannyhw
pushed a commit
that referenced
this pull request
Oct 4, 2022
authored-by: Pavlos Vinieratos <[email protected]> changes from #370
|
thank you! yep, my mistake. I totally thought that's a default "on", but I guess not 🤷. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
I noticed that sometimes it was hard to see the little button
What I did
So I made it with a double outline, so it will work on light and dark back content.
How to test
Please explain how to test your changes and consider the following questions
If your answer is yes to any of these, please make sure to include it in your PR.