Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Instrumenter: Fix preview-api import for react-native #31057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Instrumenter: Fix preview-api import for react-native #31057

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
197ee85
Update typings and refactor instrumenter to use direct import for add…
ndelangen Apr 3, 2025
a4eda8b
Refactor instrumenter to use local preview-api module for addons. Thi…
ndelangen Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions code/core/src/instrumenter/instrumenter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import type { StoryId } from 'storybook/internal/types';
import { global } from '@storybook/global';

import { processError } from '@vitest/utils/error';
import { addons } from 'storybook/preview-api';

import { EVENTS } from './EVENTS';
import type { Call, CallRef, ControlStates, LogItem, Options, State, SyncPayload } from './types';
Expand Down Expand Up @@ -235,9 +236,8 @@ export class Instrumenter {
};

// Support portable stories where addons are not available
// This is a workaround to avoid circular dependency
import('storybook/preview-api').then(({ addons }) => {
(addons ? addons.ready() : Promise.resolve()).then(() => {
if (addons) {
addons.ready().then(() => {
this.channel = addons.getChannel();

// A forceRemount might be triggered for debugging (on `start`), or elsewhere in Storybook.
Expand All @@ -261,7 +261,7 @@ export class Instrumenter {
this.channel.on(EVENTS.NEXT, next(this.channel));
this.channel.on(EVENTS.END, end);
});
});
}
}

getState(storyId: StoryId) {
Expand Down
2 changes: 1 addition & 1 deletion code/core/src/typings.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ declare var __STORYBOOK_ADDON_INTERACTIONS_INSTRUMENTER__: any;
declare var __STORYBOOK_ADDON_INTERACTIONS_INSTRUMENTER_STATE__: any;
declare var __STORYBOOK_ADDONS_CHANNEL__: any;
declare var __STORYBOOK_ADDONS_MANAGER: any;
declare var __STORYBOOK_ADDONS_PREVIEW: any;
declare var __STORYBOOK_ADDONS_PREVIEW: import('./preview-api/modules/addons/main').AddonStore;
declare var __STORYBOOK_PREVIEW__: import('./preview-api/modules/preview-web/PreviewWeb').PreviewWeb<any>;
declare var __STORYBOOK_STORY_STORE__: any;
declare var __STORYBOOK_TEST__: any;
Expand Down
Loading