Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

k35o
Copy link
Contributor

@k35o k35o commented Aug 27, 2025

storybookjs/vite-plugin-storybook-nextjs#50

What I did

Upgrading the version of vite-plugin-storybook-nextjs that @storybook/nextjs-vite depends on.
This is intended to resolve the [Error: Dynamic require of "next/dist/build/webpack/plugins/define-env-plugin.js" is not supported"] error that is occurring in the current version.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR updates the vite-plugin-storybook-nextjs dependency in the @storybook/nextjs-vite package from version ^2.0.5 to ^2.0.7. This is a targeted bug fix update that addresses a specific runtime error: Dynamic require of "next/dist/build/webpack/plugins/define-env-plugin.js" is not supported.

The @storybook/nextjs-vite framework is designed to integrate Storybook with Next.js applications using Vite as the build tool. It depends on vite-plugin-storybook-nextjs as its core plugin to handle Next.js-specific features and compatibility within the Vite environment. This plugin is essential for features like Next.js routing, image optimization, and other framework-specific functionality to work properly in Storybook.

The error being fixed appears to be related to ESM/CommonJS compatibility issues when the plugin tries to dynamically require Next.js internal modules. Version 2.0.7 of the plugin contains fixes for this compatibility issue, ensuring that Next.js features work correctly in Vite-based Storybook setups. The change maintains the caret range (^2.0.7) which follows semantic versioning practices and allows for future patch updates while ensuring the minimum version includes the necessary fixes.

PR Description Notes:

  • The manual testing section is incomplete - no specific testing steps are provided
  • None of the automated testing checkboxes are checked
  • The documentation checklist is not completed

Confidence score: 4/5

  • This is a safe dependency update with minimal risk of introducing breaking changes
  • Score reflects the straightforward nature of a patch version bump that fixes a specific known issue
  • The code/frameworks/nextjs-vite/package.json file should be reviewed to ensure the version update is correct

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Aug 27, 2025

View your CI Pipeline Execution ↗ for commit fec090d

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-16 12:52:53 UTC

@k35o
Copy link
Contributor Author

k35o commented Sep 16, 2025

Hi @ndelangen!

Would you mind reviewing this PR when you get a chance? This dependency update resolves the "Dynamic require of 'next/dist/build/webpack/plugins/define-env-plugin.js' is not supported" error that users are experiencing.

Thanks for your time! 🙏

@ndelangen ndelangen added dependencies patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Sep 16, 2025
@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Sep 16, 2025

Package Benchmarks

Commit: fec090d, ran on 16 September 2025 at 12:42:49 UTC

No significant changes detected, all good. 👏

@ndelangen ndelangen changed the title 【@storybook/nextjs-vite】 Update vite-plugin-storybook-nextjs to 2.0.7 Dependencies: Update vite-plugin-storybook-nextjs to 2.0.7 Sep 16, 2025
@ndelangen ndelangen merged commit 1043e85 into storybookjs:next Sep 16, 2025
52 checks passed
ndelangen added a commit that referenced this pull request Sep 18, 2025
…k-nextjs

Dependencies: Update `vite-plugin-storybook-nextjs` to 2.0.7
(cherry picked from commit 1043e85)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants