-
Notifications
You must be signed in to change notification settings - Fork 371
feat: Add configuration option to MCP Client for server init timeout #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zastrowm
merged 1 commit into
strands-agents:main
from
fhwilton55:add-configurable-mcp-timeout
Aug 12, 2025
Merged
feat: Add configuration option to MCP Client for server init timeout #657
zastrowm
merged 1 commit into
strands-agents:main
from
fhwilton55:add-configurable-mcp-timeout
Aug 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the contribution! |
dbschmigelski
previously approved these changes
Aug 11, 2025
zastrowm
requested changes
Aug 12, 2025
3d09949
to
514a6da
Compare
514a6da
to
44862a9
Compare
zastrowm
approved these changes
Aug 12, 2025
JackYPCOnline
added a commit
that referenced
this pull request
Aug 19, 2025
* fix: fix non-serializable parameter of agent from toolUse block * feat: Add configuration option to MCP Client for server init timeout (#657) Co-authored-by: Harry Wilton <[email protected]> * fix: Bedrock hang when exception occurs during message conversion (#643) Previously (#642) bedrock would hang during message conversion because the exception was not being caught and thus the queue was always empty. Now all exceptions during conversion are caught Co-authored-by: Mackenzie Zastrow <[email protected]> * fix: only include parameters that defined in tool spec --------- Co-authored-by: Jack Yuan <[email protected]> Co-authored-by: fhwilton55 <[email protected]> Co-authored-by: Harry Wilton <[email protected]> Co-authored-by: Mackenzie Zastrow <[email protected]> Co-authored-by: Mackenzie Zastrow <[email protected]>
dbschmigelski
pushed a commit
to dbavro19/sdk-python
that referenced
this pull request
Aug 28, 2025
…trands-agents#657) Co-authored-by: Harry Wilton <[email protected]>
dbschmigelski
pushed a commit
to dbavro19/sdk-python
that referenced
this pull request
Aug 28, 2025
…nds-agents#568) * fix: fix non-serializable parameter of agent from toolUse block * feat: Add configuration option to MCP Client for server init timeout (strands-agents#657) Co-authored-by: Harry Wilton <[email protected]> * fix: Bedrock hang when exception occurs during message conversion (strands-agents#643) Previously (strands-agents#642) bedrock would hang during message conversion because the exception was not being caught and thus the queue was always empty. Now all exceptions during conversion are caught Co-authored-by: Mackenzie Zastrow <[email protected]> * fix: only include parameters that defined in tool spec --------- Co-authored-by: Jack Yuan <[email protected]> Co-authored-by: fhwilton55 <[email protected]> Co-authored-by: Harry Wilton <[email protected]> Co-authored-by: Mackenzie Zastrow <[email protected]> Co-authored-by: Mackenzie Zastrow <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Introduces a server startup timeout configuration option in MCPClient to enable long-running startups, such as uv which can install dependencies at runtime.
Also some minor auto-formatting changes added by hatch.
Related Issues
NA
Documentation PR
NA
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.