Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: only set signature in message if signature was provided by the model #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

fix: only set signature in message if signature was provided by the model #682

merged 1 commit into from
Aug 18, 2025

Conversation

clareliguori
Copy link
Contributor

Description

I am testing Strands against the new gpt-oss model in Bedrock, and getting this error on the second turn:

strands.types.exceptions.EventLoopException: An error occurred (ValidationException) when calling the Converse operation:
This model doesn't support the reasoningContent.reasoningText.signature field. Remove reasoningContent.reasoningText.signature and try again.

When I look at the request, Strands is setting the signature to an empty string.

Type of Change

Bug fix

Testing

I tested with gpt-oss and Sonnet 4, and added a unit test.

Agent(
        system_prompt=NAMING_SYSTEM_PROMPT,
        tools=tools,
        model=BedrockModel(model_id="openai.gpt-oss-20b-1:0", streaming=False),
)

and

Agent(
        system_prompt=NAMING_SYSTEM_PROMPT,
        tools=tools,
        model=BedrockModel(model_id="us.anthropic.claude-sonnet-4-20250514-v1:0",
                           additional_request_fields={
                               "anthropic_beta": ["interleaved-thinking-2025-05-14"],
                               "thinking": {"type": "enabled", "budget_tokens": 8000},
                           }),
)
  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dbschmigelski
dbschmigelski approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@dbschmigelski dbschmigelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this :)

@dbschmigelski dbschmigelski merged commit fbd598a into strands-agents:main Aug 18, 2025
12 checks passed
dbschmigelski pushed a commit to dbavro19/sdk-python that referenced this pull request Aug 28, 2025
@clareliguori @dbschmigelski
fix: only set signature in message if signature was provided by the m…
c1f4d59 
…odel (strands-agents#682)
@dbschmigelski dbschmigelski mentioned this pull request Sep 15, 2025
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbschmigelski dbschmigelski dbschmigelski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clareliguori @dbschmigelski