fix: add system_prompt to structured_output_span before adding input_messages #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate @poshinchen and @zastrowm for some review 🙏 |
Unshure
approved these changes
Aug 21, 2025
3 tasks
dbschmigelski
pushed a commit
to dbavro19/sdk-python
that referenced
this pull request
Aug 28, 2025
…messages (strands-agents#709) * fix: add system_prompt to structured_output_span before adding input_messages * test: Add system message ordering validation to agent structured output test * Switch to ensuring exact ordering of messages --------- Co-authored-by: Dennis Tsai (RD-AS) <[email protected]> Co-authored-by: Mackenzie Zastrow <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the order of system_prompt and input_messages in
structured_output_span.The system_prompt should added before input_message, and align with the order of what sent to model_provider, inside of
model.structured_output.Related Issues
#692
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.