Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: filter 'SDK_UNKNOWN_MEMBER' from response content #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

fix: filter 'SDK_UNKNOWN_MEMBER' from response content #798

merged 1 commit into from
Sep 4, 2025

Conversation

JackYPCOnline
Copy link
Contributor

Description

This PR filter SDK_UNKNOWN_MEMBER from bedrock response when using old boto3 version.

Related Issues

#736

Documentation PR

Type of Change

Bug fix ☑️
New feature
Breaking change
Documentation update
Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • [x ] I ran hatch run prepare

Checklist

  • [x ] I have read the CONTRIBUTING document
  • [x ] I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • [x ] Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

zastrowm
zastrowm previously approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@zastrowm zastrowm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we reproduce the problem in #736 and verified that this fixes it?

I'd like to ensure that we don't end up having an empty message/content block which just throws a different exception

dbschmigelski
dbschmigelski previously approved these changes Sep 4, 2025
View reviewed changes
@JackYPCOnline JackYPCOnline reopened this Sep 4, 2025
@JackYPCOnline JackYPCOnline dismissed stale reviews from dbschmigelski and zastrowm via 6fb3362 September 4, 2025 17:08
@JackYPCOnline
Copy link
Contributor Author

I think Dean's PR add a empty content check. #652

@JackYPCOnline JackYPCOnline merged commit ed33868 into strands-agents:main Sep 4, 2025
23 of 26 checks passed
@JackYPCOnline JackYPCOnline deleted the unknown branch September 4, 2025 17:58
@zastrowm zastrowm mentioned this pull request Sep 9, 2025
Closed
3 tasks
@dbschmigelski dbschmigelski mentioned this pull request Sep 15, 2025
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zastrowm zastrowm zastrowm approved these changes

@dbschmigelski dbschmigelski dbschmigelski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackYPCOnline @zastrowm @dbschmigelski