fix: only add signature to reasoning blocks if signature is provided #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per strands-agents#790, right now we're adding a blank signature to all reasoning content, which breaks providers (openai.gpt-oss-120b-1:0) which don't provide signatures. We already add a signature if it's not already present, so the fix here is just to blank out the signature.
dbschmigelski
approved these changes
Sep 5, 2025
mehtarac
approved these changes
Sep 5, 2025
3 tasks
This was referenced Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #790, right now we're adding a blank signature to all reasoning content, which breaks providers (openai.gpt-oss-120b-1:0) which don't provide signatures. We already add a signature if it's not already present, so the fix here is just to blank out the signature.
Added some tests to catch future regressions.
Related Issues
#790, #799
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.