Fix: Add missing identifier assignment in AgentCoreBrowser.__init__ #225
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing self.identifier = identifier assignment in constructor - Update docstring to document identifier parameter - Add comprehensive test coverage for identifier parameter - Fixes AttributeError when create_browser_session() accesses self.identifier Fixes strands-agents#222
jer96
approved these changes
Aug 21, 2025
|
i see that this fix has been applied in this PR: 219. Happy to close this out in the favor of the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
AgentCoreBrowser.__init__()method accepts anidentifierparameter but never assigns it toself.identifier, causing anAttributeErrorwhencreate_browser_session()tries to access it.This PR adds the missing assignment
self.identifier = identifierin the constructor and updates the docstring to properly document the identifier parameter.Related Issues
Fixes #222
Documentation PR
N/A - This is a bug fix that doesn't require documentation changes
Type of Change
Bug fix
Testing
How have you tested the change?
Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.