Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove Node 18 support and misc. cleanup #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

Conversation

derrickmehaffy
Copy link
Member

What does it do?

  • Removes/updates references of node 18 to node 20/22
  • Fixes dockerfile examples with updated node version
  • Fixes very outdated security policy (copied from main monorepo)
  • Various other little cleanups

Why is it needed?

Node 18 is now end of life as of 2025-04-30: https://endoflife.date/nodejs

image

Related issue(s)/PR(s)

N/A

Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 8:58am

README.md Outdated
@@ -37,7 +37,7 @@ Additional official Strapi documentation websites cover different content:

The following are required if you are submitting pull requests to the documentation:

- NodeJS >=16.14 <=18.x.x
- NodeJS >=20.0.0 <=22.x.x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is true for Docusaurus. I'm still running it on 18.x and it works fine. We'll postpone this update I believe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's end of life though, no one should be using versions below 20

Copy link
Collaborator

@pwizla pwizla May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get where you're coming from and I understand your concerns. We'll wait for Docusaurus itself to update its own requirements, though. 18.0 is still listed on the dependencies for the latest version of Docusaurus— 3.7.0 (for instance here, https://docusaurus.io/docs/installation) and it's known to lag a bit behind because of Node-related bugs when upgrading 😅

@pwizla pwizla changed the title chore: remove node 18 support and misc cleanup Remove Node 18 support and misc. cleanup May 7, 2025
@pwizla pwizla added this to the 6.2.3 milestone May 7, 2025
@pwizla pwizla added the temp - port to docs-next (Temporary label) The content of this PR should be ported to docs-next.strapi.io label May 7, 2025
@pwizla pwizla merged commit 0795c09 into main May 7, 2025
15 of 16 checks passed
@pwizla pwizla deleted the chore/nodeVersionUpgrade branch May 7, 2025 08:57
pwizla added a commit that referenced this pull request May 7, 2025
* chore: remove node 18 support and misc cleanup

* Update README.md

* Update SECURITY.md

---------

Co-authored-by: Pierre Wizla <[email protected]>
pwizla added a commit that referenced this pull request May 7, 2025
* chore: remove node 18 support and misc cleanup

* Update README.md

* Update SECURITY.md

---------

Co-authored-by: Pierre Wizla <[email protected]>
@pwizla pwizla added this to the 6.3.0 milestone May 7, 2025
pwizla added a commit that referenced this pull request May 7, 2025
* chore: remove node 18 support and misc cleanup

* Update README.md

* Update SECURITY.md

---------

Co-authored-by: DMehaffy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore source: CMS temp - port to docs-next (Temporary label) The content of this PR should be ported to docs-next.strapi.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants