ffmpegmux: use -start_at_zero with -copyts#2559
Merged
Merged
Conversation
- fixes invalid timestamp on recorded files - fixes invalid timestamp on live player cache playback - starts the timestamp always at 0 if -copyts was used - removed wrong called log, it should have been `self.logger` when it was changed it was only used for one line instead of all at the moment.
beardypig
approved these changes
Jul 21, 2019
beardypig
left a comment
Member
There was a problem hiding this comment.
Looks good to me, I tested adding the option and it always seemed to work.
Member
|
Looks good @back-to. @beardypig Feel free to just merge after a review. I don't think we have any procedure around requiring more than one person. |
Member
|
Sometimes I like to wait in case op makes a change, or someone else wants to weigh in :) |
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
ffmpegmux: use -start_at_zero with -copyts
1 task
back-to
added a commit
to back-to/streamlink
that referenced
this pull request
Dec 13, 2020
- don't use `-start_at_zero` as default for `-copyts` - revert streamlink#2559 - change command `--ffmpeg-no-start-at-zero` to `--ffmpeg-start-at-zero` (there was no release in between this command) - use `--ffmpeg-start-at-zero` for the facebook plugin, because the original fix was for it. streamlink#2488
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 15, 2020
…lt (streamlink#3413) - don't use `-start_at_zero` as default for `-copyts` - revert streamlink#2559 - change command `--ffmpeg-no-start-at-zero` to `--ffmpeg-start-at-zero` (there was no release in between this command) - use `--ffmpeg-start-at-zero` for the facebook plugin, because the original fix was for it. streamlink#2488
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 17, 2020
…lt (streamlink#3413) - don't use `-start_at_zero` as default for `-copyts` - revert streamlink#2559 - change command `--ffmpeg-no-start-at-zero` to `--ffmpeg-start-at-zero` (there was no release in between this command) - use `--ffmpeg-start-at-zero` for the facebook plugin, because the original fix was for it. streamlink#2488
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.loggerwhen it was changedit was only used for one line instead of all at the moment.
Fixes #2488